From 3a39e285e7091186623c354516741c70fe3d0796 Mon Sep 17 00:00:00 2001
From: Artem Dychenko <s192441@student.pg.edu.pl>
Date: Tue, 25 Feb 2025 17:58:20 +0100
Subject: [PATCH] review changes
---
.../dashboard/dashboard.component.html | 2 +-
.../dashboard/dashboard.component.scss | 28 ++-----------------
.../dashboard/dashboard.component.ts | 10 ++-----
src/vars.scss | 2 +-
4 files changed, 7 insertions(+), 35 deletions(-)
diff --git a/src/app/components/dashboard/dashboard.component.html b/src/app/components/dashboard/dashboard.component.html
index 750b51c..3545ab2 100644
--- a/src/app/components/dashboard/dashboard.component.html
+++ b/src/app/components/dashboard/dashboard.component.html
@@ -2,7 +2,7 @@
<div title>Monitoring and Analysis</div>
<div actions class="actions">
- <button mat-fab class="settings-button" (click)="doNothing()">
+ <button mat-fab class="settings-button" (click)="openSettings()">
<mat-icon>settings</mat-icon>
</button>
</div>
diff --git a/src/app/components/dashboard/dashboard.component.scss b/src/app/components/dashboard/dashboard.component.scss
index ce81b2a..1938814 100644
--- a/src/app/components/dashboard/dashboard.component.scss
+++ b/src/app/components/dashboard/dashboard.component.scss
@@ -10,12 +10,11 @@
gap: map.get(vars.$spacing, 'md');
.settings-button {
- border-radius: map.get(vars.$radius, 'xs');
- padding: map.get(vars.$spacing, 'xs') map.get(vars.$spacing, 'xs');
+ box-shadow: none;
mat-icon {
- font-size: 1.5rem;
- color: white;
+ font-size: map.get(vars.$text, 'xl');
+ color: map.get(vars.$grey, 0);
}
}
@@ -24,35 +23,14 @@
}
}
-
-
-
-
.accordion__panel {
- border-radius: map.get(vars.$radius, 'xs');
background-color: map.get(vars.$grey, 10);
- padding: map.get(vars.$spacing, 'xs') map.get(vars.$spacing, 'xs');
box-shadow: 0 2px 5px rgba(0, 0, 0, 0.2);
-
border-bottom: 1px solid map.get(vars.$grey, 30);
&:last-child {
border-bottom: none;
}
-
- &-header {
- display: flex;
- align-items: center;
- justify-content: space-between;
- transition: background-color 0.3s ease-in-out;
-
- &:hover {
- background-color: map.get(vars.$grey, 30);
- }
- }
}
-
}
-
-
diff --git a/src/app/components/dashboard/dashboard.component.ts b/src/app/components/dashboard/dashboard.component.ts
index 72f611c..f7bc6d7 100644
--- a/src/app/components/dashboard/dashboard.component.ts
+++ b/src/app/components/dashboard/dashboard.component.ts
@@ -1,11 +1,7 @@
-import { Component, signal } from '@angular/core';
+import { Component } from '@angular/core';
import { PageWrapperComponent } from '../page-wrapper/page-wrapper.component';
import { Skeleton } from 'primeng/skeleton';
import { MatExpansionModule } from '@angular/material/expansion';
-import {
- MatExpansionPanel,
- MatExpansionPanelTitle,
-} from '@angular/material/expansion';
import { MatIcon } from '@angular/material/icon';
import { MatFabButton } from '@angular/material/button';
@@ -13,8 +9,6 @@ import { MatFabButton } from '@angular/material/button';
selector: 'app-dashboard',
imports: [
Skeleton,
- MatExpansionPanel,
- MatExpansionPanelTitle,
MatExpansionModule,
MatIcon,
PageWrapperComponent,
@@ -24,5 +18,5 @@ import { MatFabButton } from '@angular/material/button';
styleUrl: './dashboard.component.scss',
})
export class DashboardComponent {
- doNothing() {}
+ openSettings() {}
}
diff --git a/src/vars.scss b/src/vars.scss
index 86e2872..4cdf01f 100644
--- a/src/vars.scss
+++ b/src/vars.scss
@@ -1,4 +1,4 @@
-$textPrimary: #9c0c0c;
+$textPrimary: #520000;
$error: #ff2525;
$sidenavWidth: 256px;
$headerHeight: 68px;
--
GitLab